A Study of the Quality-Impacting Practices of Modern Code Review at Sony Mobile
A Study of the Quality-Impacting Practices of Modern Code Review at Sony Mobile
复制标题
DOI：
10.1145/2889160.2889243
复制
发表时间：
2016-05
期刊：
影响因子：
--
通讯作者：
Junji Shimagaki;Yasutaka Kamei;Shane McIntosh;A. Hassan;Naoyasu Ubayashi
中科院分区：
文献类型：
--
作者：
Junji Shimagaki;Yasutaka Kamei;Shane McIntosh;A. Hassan;Naoyasu Ubayashi
如今，代码审查过程的一个灵活、轻量级的变体（即，让其他团队成员评论软件更改的做法）被开源和专有软件项目所采用。虽然这种灵活性是一种祝福（例如，使代码审查能够跨越地球仪），它不像过去的正式代码检查那样强制规定最低审查质量标准。最近的研究表明，松懈的审查会影响开源系统的质量。在本文中，我们调查了代码审查实践对索尼移动的开发的专有系统质量的影响。我们开始通过复制开源软件质量（近似于发布后的缺陷倾向）和以下两者之间关系的分析：（1）代码审查覆盖率，即，已审查的代码变更比例;（2）代码审查参与情况，即，评审员参与代码评审过程的程度。我们还进行了定性分析，与93个利益相关者的调查，半结构化访谈15个利益相关者，和25个高级工程师的后续调查。我们的研究结果表明，虽然过去的审查覆盖率和参与度的措施不共享的关系，在索尼移动的缺陷倾向，审查措施，知道索尼移动的开发环境与缺陷倾向。我们的研究结果导致索尼移动的代码审查过程的改进。
Nowadays, a flexible, lightweight variant of the code review process (i.e., the practice of having other team members critique software changes) is adopted by open source and proprietary software projects. While this flexibility is a blessing (e.g., enabling code reviews to span the globe), it does not mandate minimum review quality criteria like the formal code inspections of the past. Recent work shows that lax reviewing can impact the quality of open source systems. In this paper, we investigate the impact that code reviewing practices have on the quality of a proprietary system that is developed by Sony Mobile. We begin by replicating open source analyses of the relationship between software quality (as approximated by post-release defect-proneness) and: (1) code review coverage, i.e., the proportion of code changes that have been reviewed and (2) code review participation, i.e., the degree of reviewer involvement in the code review process. We also perform a qualitative analysis, with a survey of 93 stakeholders, semi-structured interviews with 15 stakeholders, and a follow-up survey of 25 senior engineers. Our results indicate that while past measures of review coverage and participation do not share a relationship with defect-proneness at Sony Mobile, reviewing measures that are aware of the Sony Mobile development context are associated with defect-proneness. Our results have lead to improvements of the Sony Mobile code review process.